Skip to content

fix(location-strategy): crash on going back with router-outlet after closing modal #1750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 26, 2019
Merged

fix(location-strategy): crash on going back with router-outlet after closing modal #1750

merged 2 commits into from
Feb 26, 2019

Conversation

ADjenkov
Copy link
Contributor

Fix #1735

@ADjenkov
fix(location-strategy): crash on going back with router-outlet after …
0ed7de6 
…closing modal (#1748)

* fix(location-strategy): crash on going back with router-outlet after closing modal

* tests: add e2e tests in single-page app

* chore: bump version to 7.2.2
@cla-bot cla-bot bot added the cla: yes label Feb 26, 2019
@ghost ghost assigned ADjenkov Feb 26, 2019
@ghost ghost added the in progress label Feb 26, 2019
@ADjenkov ADjenkov merged commit 9b3a3ba into master Feb 26, 2019
@ADjenkov ADjenkov deleted the djenkov/release-to-master branch February 26, 2019 12:03
@ghost ghost removed the in progress label Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartoYankov MartoYankov MartoYankov approved these changes

Assignees

@ADjenkov ADjenkov

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ADjenkov @MartoYankov